Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruff-base.toml to discourage using assert in code except for tests #1426

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Update ruff-base.toml to discourage using assert in code except for tests #1426

merged 1 commit into from
Oct 30, 2024

Conversation

taldcroft
Copy link
Member

jeanconn
jeanconn approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. This is what I had in mind with that comment.

@taldcroft taldcroft merged commit ac70d31 into master Oct 30, 2024
@taldcroft taldcroft deleted the taldcroft-patch-1 branch October 30, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanconn jeanconn jeanconn approved these changes

@javierggt javierggt Awaiting requested review from javierggt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taldcroft @jeanconn